Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for recent version during calls? #1681

Closed
angerman opened this issue Jan 20, 2016 · 10 comments

Comments

Projects
None yet
6 participants
@angerman
Copy link
Contributor

commented Jan 20, 2016

The cocoa pods pod command checks for the latest version upon each invocation, and lets one know if there is a newer version available. I would like to see such a feature added to stack.

@mgsloan

This comment has been minimized.

Copy link
Collaborator

commented Jan 20, 2016

Hmm, interesting idea! Thoughts:

  • May be worthwhile to have logic for doing this request occasionally rather than every stack invocation.
  • Maybe only do anything for "stack build" calls? Doing this for invocations like stack path seems excessive.
  • It'd be good to have a way to disable it, asome folks might not appreciate the misc bandwidth use (tethering with cellphones). The offline flag is also relevant.
@angerman

This comment has been minimized.

Copy link
Contributor Author

commented Jan 20, 2016

I guess it depends on:

  • how fast ist the check? Say if haskellstack.org/latest returns just the version number, that could be pretty quick.
  • how frequent do we want to check (once per day?)

For disabling it:

  • allow option to disable it; this could be considered tracking
    NB: cocoa pods even does some additional tracking on which packages are used; this rubs some the very wrong way, understandably.

So either go with ~/.stack/config.yaml and or an environment variable?

@mgsloan mgsloan added this to the P3: Optional milestone Jan 20, 2016

@mgsloan

This comment has been minimized.

Copy link
Collaborator

commented Jan 20, 2016

Once per day seems reasonable. Doing a check is fast, but it's still a network request, seems best to avoid doing lots of them.

NB: cocoa pods even does some additional tracking on which packages are used; this rubs some the very wrong way, understandably.

It'd be cool to have an opt-in option for this. It'd be cool to see what things are most popular, and infer related sets of packages ("often used with: ...").

So either go with ~/.stack/config.yaml and or an environment variable?

Yeah, makes sense!

@angerman

This comment has been minimized.

Copy link
Contributor Author

commented Jan 20, 2016

Ohh there's another thing, I did not mentioned. When something goes wrong, they basically provide you all the information to create a useful issue, though they advise you to clean up all potential private data.

@angerman

This comment has been minimized.

Copy link
Contributor Author

commented Jan 20, 2016

Here's the relevant statistics post from cocoa pods, for the record:

@mgsloan

This comment has been minimized.

Copy link
Collaborator

commented Feb 5, 2016

I'm bumping this to P2: Should, because I've been seeing lots of bug reports from people using their distro version and encountering things that have been fixed. While this won't solve things for those current versions, once the distro versions ship the thing with the check, this will hopefully happen less.

@mgsloan mgsloan modified the milestones: P2: Should, P3: Optional Feb 5, 2016

@borsboom

This comment has been minimized.

Copy link
Contributor

commented Feb 7, 2016

I just added a note to CONTRIBUTING.md to check using the latest version
before reporting a bug. Not everyone actually looks at that before
reporting, but hopefully it will at least reduce the number of incidences.

@mgsloan

This comment has been minimized.

Copy link
Collaborator

commented Apr 18, 2016

It would also be nice to have this check for deprecated versions. Would be really handy in circumstances like #2000 where we'd like to get users off affected versions.

@chrisdone

This comment has been minimized.

Copy link
Member

commented Apr 28, 2016

I'd also suggest doing the check when in the terminal. Many stack invocations are run by other tooling, so it would be hidden, and a waste of resources. In the terminal at least gives a higher probability of the user actually seeing it.

@sjakobi

This comment has been minimized.

Copy link
Contributor

commented Jul 14, 2016

@borsboom commented on #2355 (duplicate):

It would make sense to implement this in conjunction with #1238 (have stack upgrade download a new binary when possible rather than building from source).

snoyberg added a commit that referenced this issue Apr 14, 2019

snoyberg added a commit that referenced this issue Apr 15, 2019

@snoyberg snoyberg modified the milestones: P2: Should, Stack 2.0 Apr 22, 2019

@snoyberg snoyberg closed this in e9ec927 Apr 22, 2019

snoyberg added a commit that referenced this issue Apr 22, 2019

Merge pull request #4729 from commercialhaskell/1681-check-recent-ver…
…sion

Recommend Stack upgrade when appropriate (fixes #1681)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.