Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No cabal file found for Archive #4292

Closed
waddlaw opened this issue Sep 5, 2018 · 6 comments
Closed

No cabal file found for Archive #4292

waddlaw opened this issue Sep 5, 2018 · 6 comments

Comments

@waddlaw
Copy link
Contributor

@waddlaw waddlaw commented Sep 5, 2018

Steps to reproduce

  1. create new project.
$ stack new sample
$ cd sample
  1. edit stack.yaml (add extra-deps)
$ cat stack.yaml
resolver:
  url: https://raw.githubusercontent.com/commercialhaskell/stackage-snapshots/master/lts/12/9.yaml

packages:
- .
extra-deps:
- github: fpco/store
  commit: 247f2863bed0f5c1003ab835075b6dcafb9aa773
  1. build project
$ stack build
No cabal file found for Archive from https://github.com/fpco/store/archive/247f2863bed0f5c1003ab835075b6dcafb9aa773.tar.gz

Some packages will succeed.(ex. cassava)

extra-deps:
- git: https://github.com/haskell-hvr/cassava.git
  commit: 151f74b976ce93c59e938ae130324bec53ac8c92
# - github: fpco/store
#   commit: 247f2863bed0f5c1003ab835075b6dcafb9aa773

Stack version

$ stack --version
Version 1.10.0, Git revision 388232c3f3ae350e384b2e41c0c11606fd06b69e (6449 commits) x86_64 hpack-0.30.0
@brandon-leapyear
Copy link
Contributor

@brandon-leapyear brandon-leapyear commented Sep 6, 2018

Also breaks if you include

subdirs:
- .

Error is in Pantry.Archive stripping prefix of a path instead of stripping subdirectories. e.g. specifying

subdirs:
- foo/bar

in a repository with the path foo/bar-asdf.cabal, it will resolve this as -asdf.cabal

@waddlaw
Copy link
Contributor Author

@waddlaw waddlaw commented Sep 15, 2018

@brandon-leapyear @mihaimaruseac
thanks! But, still unsolved problem...

I think that parseArchive is cause.

https://github.com/commercialhaskell/stack/blob/master/subs/pantry/src/Pantry/Archive.hs#L392

...
(cabalPath, cabalEntry@(TreeEntry cabalBlobKey _)) <- findCabalFile pli tree
...

With this implementation, it's necessary .cabal file in the archive. (don't auto generate from package.yaml)

We must to contains .cabal files in archive, even if exist package.yaml?

@mihaimaruseac
Copy link
Contributor

@mihaimaruseac mihaimaruseac commented Sep 16, 2018

Reopening in that case, the file should be regenerated

@mihaimaruseac mihaimaruseac reopened this Sep 16, 2018
@quasicomputational
Copy link

@quasicomputational quasicomputational commented Sep 16, 2018

This is in the same region as #2255 and #4267.

@snoyberg
Copy link
Contributor

@snoyberg snoyberg commented Oct 25, 2018

Please see #4377.

@snoyberg
Copy link
Contributor

@snoyberg snoyberg commented Jan 18, 2019

Fixed by #4439

@snoyberg snoyberg closed this Jan 18, 2019
georgewsinger pushed a commit to SimulaVR/godot-extra that referenced this issue Mar 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants