Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stack upgrade goes through entire build process, even when already up to date #447

Closed
ojw opened this issue Jun 29, 2015 · 2 comments
Closed
Assignees
Milestone

Comments

@ojw
Copy link

@ojw ojw commented Jun 29, 2015

Steps to reproduce:

Run stack upgrade.
After the upgrade, immediately run stack upgrade again.

Expected:
Stack will notice that it is up-to-date and not run the full build process the second time, probably reporting a message that it is up-to-date already.

Actual:
Stack runs through the build process again.

Here is the stack --version output:
Version 0.1.1.0, Git revision 91fe703

For the second run, the stack --version is:
Version 9.9.9

Here is the output of the command when I ran with stack upgrade --verbose:
http://pastebin.com/pZhc6t0n

@snoyberg snoyberg added this to the 0.2.0.0 milestone Jun 29, 2015
@snoyberg
Copy link
Contributor

@snoyberg snoyberg commented Jun 29, 2015

Agreed, I commented on this limitation but forgot to open an issue about it. We should solve it. The 9.9.9 issue is a separate one, and a limitation of Hackage it seems...

@snoyberg snoyberg self-assigned this Jul 2, 2015
@snoyberg snoyberg added the ready label Jul 2, 2015
snoyberg added a commit that referenced this issue Jul 5, 2015
@snoyberg
Copy link
Contributor

@snoyberg snoyberg commented Jul 5, 2015

I've pushed a commit for this. It doesn't do anything for the Git case, since that seems like a corner case to deal with, but when running stack upgrade, it will do nothing if the upstream version if <= the current version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.