Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop nagging people that call `stack test` #845

Closed
bitemyapp opened this issue Aug 24, 2015 · 8 comments
Closed

Stop nagging people that call `stack test` #845

bitemyapp opened this issue Aug 24, 2015 · 8 comments
Milestone

Comments

@bitemyapp
Copy link
Contributor

@bitemyapp bitemyapp commented Aug 24, 2015

/cc @chreekat

NOTE: the test command is functionally equivalent to 'build --test'

baits people into typing more for no functional purpose. If the issue is with build target discoverability, we should fix the docs or command-line help.

@cocreature
Copy link
Contributor

@cocreature cocreature commented Aug 24, 2015

The same also goes for stack install. I realize that some people might be confused, but if you don't plan to remove the commands and they are accepted, I don't see why I need to see a big warning every time I run them.

@bitemyapp
Copy link
Contributor Author

@bitemyapp bitemyapp commented Aug 24, 2015

I agree @cocreature - it confuses people into thinking they're deprecated when they're not.

@snoyberg
Copy link
Contributor

@snoyberg snoyberg commented Aug 25, 2015

As the guy who wrote those comments: I agree, let's kill them. The --help output already explains this, which is sufficient. Does someone else want to send a PR for this? It's some easy changes in src/main/Main.hs (my internet is acting up right now).

@snoyberg snoyberg added this to the 0.2.0.0 milestone Aug 25, 2015
@snoyberg
Copy link
Contributor

@snoyberg snoyberg commented Aug 25, 2015

Internet fixed, and...

@snoyberg snoyberg closed this in 02a6b7f Aug 25, 2015
@cocreature
Copy link
Contributor

@cocreature cocreature commented Aug 25, 2015

Thanks!

@bitemyapp
Copy link
Contributor Author

@bitemyapp bitemyapp commented Aug 25, 2015

Thank you @snoyberg :)

@snoyberg
Copy link
Contributor

@snoyberg snoyberg commented Aug 25, 2015

Sure. It was bugging me too.

On Tue, Aug 25, 2015 at 7:05 PM, Chris Allen notifications@github.com
wrote:

Thank you @snoyberg https://github.com/snoyberg :)


Reply to this email directly or view it on GitHub
#845 (comment)
.

@simonmichael
Copy link
Contributor

@simonmichael simonmichael commented Sep 4, 2015

Thanks! :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.