Drop Data.Yaml.Extra #2491 #2793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -76,6 +76,7 @@ extra-deps: | |||
| - text-metrics-0.1.0 | |||
| - pid1-0.1.0.0 | |||
| - file-embed-0.0.10 | |||
| - yaml-0.8.20 | |||
There was a problem hiding this comment.
I expect we'll need this - yaml-0.8.20 also in stack.yaml and stack-8.0.yaml since the snapshots use older versions, but CI will tell.
There was a problem hiding this comment.
Doh, I'm confusing myself with these separate PRs, I'd already bumped the LTS versions in a separate one. I'll do that here too.
There was a problem hiding this comment.
OK, should work now!
|
LGTM—it reverts everything in #2492, matches the plan in #2491 (comment), and updates the dependency in the cabal file. |
This has been fixed upstream, see: snoyberg/yaml#91
snoyberg
force-pushed
the
2491-drop-data-yaml-extra
branch
from
643725a
to
49de6e4
Compare
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has been fixed upstream, see:
snoyberg/yaml#91