Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report currently building packages along with "Progress:" label #3763

Merged
merged 3 commits into from Jan 15, 2018

Conversation

develop7
Copy link
Contributor

Rationale: make user feel more "in control" when waiting for these tens to hundreds of packages to be built by providing information on what is building now.

Build progress line

beforeProgress: 3/74
and
afterProgress: 3/74; [Cabal-2.0.1.1|basement-0.0.4|old-time-1.1.0.3|simple-sendfile-0.2.26|stm-2.4.4.1|stringsearch-0.3.6.6]
applying this change.

Limitations: configure and copy/register stages are not covered, would require refactoring. Since these are quite fast, covering them might not worth the effect.

Note: Documentation fixes for https://docs.haskellstack.org/en/stable/ should target the "stable" branch, not master.

Please include the following checklist in your PR:

  • Any changes that could be relevant to users have been recorded in the ChangeLog.md
  • The documentation has been updated, if necessary.

Rationale: make user feel more "in control" when waiting for these tens
to hundreds of packages to be built by providing information on what is
going on *right now*.
@mgsloan
Copy link
Contributor

mgsloan commented Jan 13, 2018

Great! This is a step along the way to #3667

I find the use of ; and [..|..|..] a bit unprecedented, though. I think I'd prefer something more like what's described in the above issue. It'd be greatly appreciated to do the other changes in the issue.
That's not needed to get this merged, though.

To get it merged, I'd like it to read Progress 3/74: Cabal-2.0.1.1, basement-0.0.4, old-time-1.1.0.3, simple-sendfile-0.2.26, stm-2.4.4.1, stringsearch-0.3.6.6, since I think that looks nicer. It'd probably also make sense to use the pretty print stuff to give emphasis to the progress number and maybe give a style to each package name.

Edit: oops, hit the wrong button and closed.

@mgsloan mgsloan closed this Jan 13, 2018
@mgsloan mgsloan reopened this Jan 13, 2018
@develop7
Copy link
Contributor Author

@mgsloan got it, will do in a jiffy!

@develop7
Copy link
Contributor Author

@mgsloan done! Thanks for the feedback!

@develop7
Copy link
Contributor Author

For the record, failed build doesn't mention files I've changed

@mgsloan
Copy link
Contributor

mgsloan commented Jan 15, 2018

LGTM, thanks!

@mgsloan mgsloan merged commit d1481a6 into commercialhaskell:master Jan 15, 2018
@snoyberg
Copy link
Contributor

I just noticed this change while doing some dev and using bleeding edge Stack. THANK YOU, this is a great usability improvement 😄

@vincenthz
Copy link
Contributor

vincenthz commented Jan 23, 2018

looking forward to use this in production too ! small change, great usability improvement. thanks @develop7

@develop7
Copy link
Contributor Author

Whoa, I guess I've hit a bullseye here! Thank you! Can't wait to see it in action as well! Do not feel hardcore enough to switch to nightly stack though ;)

@snoyberg
Copy link
Contributor

snoyberg commented Jan 23, 2018 via email

@develop7
Copy link
Contributor Author

 Let your stuff break regularly, it's awesome :)

Totally agree, though I kind of feel better having it under control :) More as a time-saver, as my day job doesn't involve Haskell at all

then I just rm -rf ~/.stack

Ya, did that maybe three times, works awesome since 1.6 though!

@develop7 develop7 deleted the feature-currently-building branch April 12, 2019 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants