New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When a cabal file can't be found, warn that extra-deps could be the problem too #3808

Merged
merged 1 commit into from Jan 25, 2018

Conversation

Projects
None yet
2 participants
@MaxGabriel
Contributor

MaxGabriel commented Jan 25, 2018

  • Also: slight refactor to use only concat instead of ++ in the error message
  • Also: mention that a package.yaml file would also be accepted
    • The code that throws this is only searching for a .cabal file, but it runs hpack on the directory immediately before that to generate a cabal file, so it's effectively looking for a package.yaml file as well

Closes #3806

Note: Documentation fixes for https://docs.haskellstack.org/en/stable/ should target the "stable" branch, not master.

Please include the following checklist in your PR:

  • Any changes that could be relevant to users have been recorded in the ChangeLog.md
  • The documentation has been updated, if necessary. [Not necessary]

Please also shortly describe how you tested your change. Bonus points for added tests!

I used stack install to install my changes, then ran that executable:

image

@MaxGabriel MaxGabriel force-pushed the MaxGabriel:warnExtraDeps branch from 08ab452 to 8852ecf Jan 25, 2018

When a cabal file can't be found, warn that extra-deps could be the p…
…roblem too.

* Also: slight refactor to use only `concat` instead of ++ in the error message
* Also: mention that a package.yaml file would also be accepted
	* The code that throws this is only searching for a .cabal file, but it runs hpack on the directory immediately before that to generate a cabal file, so it's effectively looking for a package.yaml file as well

Closes #3806

@MaxGabriel MaxGabriel force-pushed the MaxGabriel:warnExtraDeps branch from 8852ecf to fa3ffbe Jan 25, 2018

@mgsloan

This comment has been minimized.

Collaborator

mgsloan commented Jan 25, 2018

LGTM, thanks! 👍

@mgsloan mgsloan merged commit 5660e1b into commercialhaskell:master Jan 25, 2018

1 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment