Warning about GHCJS use when constructing a build plan #4154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bitemyapp
changed the title
snoyberg
requested changes
Jul 15, 2018
bitemyapp
changed the title
|
@snoyberg How's this changelog message? It seemed to fit "major change" in my head. |
snoyberg
approved these changes
Jul 16, 2018
…-warning-ghcjs Warning about GHCJS use when constructing a build plan
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4086
I tested it (produced the output cited in the issue above) by building miso.
Only issue with how it presently works is that people might miss the warning if it's at the start rather than the end. Do we have a means of registering warnings that should get emitted at the end by
mainor similar?