Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd --ignore-subdirs flag to init command #435
Conversation
markus1189
reviewed
Jun 27, 2015
| @@ -275,7 +275,7 @@ loadBuildConfig menv mproject config stackRoot mresolver noConfigStrat = do | ||
| Nothing -> case noConfigStrat of | ||
| ThrowException -> do | ||
| currDir <- getWorkingDir | ||
| cabalFiles <- findCabalFiles currDir | ||
| cabalFiles <- findCabalFiles True currDir |
This comment has been minimized.
This comment has been minimized.
markus1189
Jun 27, 2015
Contributor
I just passed in True here, can someone have a look if this might be problematic if init was called with the --ignore-subdirs flag?
This comment has been minimized.
This comment has been minimized.
added a commit
that referenced
this pull request
Jun 27, 2015
snoyberg
merged commit 7db9424
into
commercialhaskell:master
Jun 27, 2015
1 check passed
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
This comment has been minimized.
This comment has been minimized.
|
Thank you! |
added a commit
that referenced
this pull request
Jun 27, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
markus1189 commentedJun 27, 2015
Currently
stack inittakes into account all .cabal files in the cwd as well as non-ignored sub directories. If I run it on thestackproject it will for example also pick up thenew-template.cabaland refuse all of the available build plans due to unresolved packages like
acme-dontthat are used in some of the integration tests.With the new flag
stack init --ignore-subdirsit will only considerstack.cabaland not recurse into sub directories.To allow this I added a boolean flag to
findCabalFileswhich I don't like that much but I avoided to define a data type for the argument (e.gdata FindCabalRecurse = DoRecurse | Don'tRecurse) for simplicity.