Add --ignore-subdirs flag to init command #435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -275,7 +275,7 @@ loadBuildConfig menv mproject config stackRoot mresolver noConfigStrat = do | |||
| Nothing -> case noConfigStrat of | |||
| ThrowException -> do | |||
| currDir <- getWorkingDir | |||
| cabalFiles <- findCabalFiles currDir | |||
| cabalFiles <- findCabalFiles True currDir | |||
There was a problem hiding this comment.
I just passed in True here, can someone have a look if this might be problematic if init was called with the --ignore-subdirs flag?
There was a problem hiding this comment.
No, this looks completely correct to me.
snoyberg
added a commit
that referenced
this pull request
Jun 27, 2015
Add --ignore-subdirs flag to init command
|
Thank you! |
snoyberg
added a commit
that referenced
this pull request
Jun 27, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
stack inittakes into account all .cabal files in the cwd as well as non-ignored sub directories. If I run it on thestackproject it will for example also pick up thenew-template.cabaland refuse all of the available build plans due to unresolved packages like
acme-dontthat are used in some of the integration tests.With the new flag
stack init --ignore-subdirsit will only considerstack.cabaland not recurse into sub directories.To allow this I added a boolean flag to
findCabalFileswhich I don't like that much but I avoided to define a data type for the argument (e.gdata FindCabalRecurse = DoRecurse | Don'tRecurse) for simplicity.