-
Notifications
You must be signed in to change notification settings - Fork 842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
For windowsintegersimple resolve flags as if Windows OS #495
Conversation
I'm out for the holiday weekend, so do whatever you wish to this in the meantime. I'll be back Monday. |
I think there's still something afoot. I wonder if there's a Cabal version mismatch, but my builds are failing. More details next week if you don't beat me to it. |
FWIW:
|
Also, perhaps something needs to be uploaded still?
|
@@ -47,7 +47,7 @@ import qualified Data.Set as S | |||
import qualified Data.Text as T | |||
import Data.Text.Encoding (encodeUtf8, decodeUtf8) | |||
import qualified Data.Yaml as Yaml | |||
import Distribution.System (OS (Windows), Platform (..), buildPlatform) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change appears unnecessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops... true.
Actually, looks verygood. There are two seemingly unnecessary import changes, but that's not a problem. Merging, thanks! |
For windowsintegersimple resolve flags as if Windows OS
@snoyberg Any idea what's going on with |
No I'm not sure. I can try to investigate next week, but I don't have much On Fri, Jul 3, 2015, 10:17 AM Elliot Cameron notifications@github.com
|
I think there must still be something amiss with the build plan because it works when I hijack the GHC installation. In other words, the following process produces a working build:
I've also noticed that the |
Also note that when hijacking the GHC folder, I cannot build my project without specifying custom flags to turn off integer-gmp. It fails with an error that I need |
Perhaps treating |
I think you're right, we will need some kind of extra tagging for GHC builds. I think @manny-fp is going to need something like that for adding variants of GHC for Linux based on GMP versions. Perhaps you two could come up with some kind of a plan for what this would look like? I think basically we just want to extend |
So would we want to use the extended Platform basically wherever Distribution.System.Platform is used now (in the configuration, etc)? Having only glanced at the code, that looks like it would probably work. I could move the libgmp.so.3 detecting code (15ce80c) to where the config is loaded, and that would allow it to be overridden on the command-line. |
Yes, that's my idea, and make sure that all directories (such as inside On Fri, Jul 3, 2015 at 3:37 PM Emanuel Borsboom notifications@github.com
|
That's the direction I was thinking too when I asked the question. Being largely unfamiliar with the code, I can't tell if |
It almost seems as if GHC could merely be part of the dependency tree somehow. Of course, it would not fall under the treatment of typical cabal dependencies. I suppose this connection is already present with the |
Shall I open a new issue to add custom build tagging on the |
Discussing in a new issue is a good idea |
I have very little confidence I did this right, but here's my good faith effort. :)
See #399