Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show warning about local-programs-path with spaces on windows when running scripts #5013

Merged
merged 4 commits into from Aug 30, 2019

Conversation

jneira
Copy link
Contributor

@jneira jneira commented Aug 20, 2019

Please include the following checklist in your PR:

  • Any changes that could be relevant to users have been recorded in the ChangeLog.md
  • The documentation has been updated, if necessary.

It seems that warn messages are not shown when running a script so the more straigthforward way is change the log level of the relevant message. Not sure it it could have a unwanted consequence.
It fixes #5001.

I've tested the change manually running a script to check the message is actually shown.

@jneira jneira changed the title Show warning about local-programs-path with spaces on windows Show warning about local-programs-path with spaces on windows when running scripts Aug 20, 2019
Copy link
Contributor

@dbaynard dbaynard left a comment

Let's fix the the current 'shortest' path text. Otherwise, we do want to catch (and error) in these circumstances on windows.

The docs help, a little.

src/Stack/Config.hs Outdated Show resolved Hide resolved
jneira and others added 2 commits Aug 21, 2019
Co-Authored-By: David Baynard <dbaynard@users.noreply.github.com>
@jneira
Copy link
Contributor Author

@jneira jneira commented Aug 21, 2019

@dbaynard not sure about the best way to inform the user, but it seems that show the original value of local-programs-path could help it to identify and change it.

Copy link
Member

@mattaudesse mattaudesse left a comment

Thanks @jneira - looks good to me.

@mattaudesse mattaudesse merged commit 218b14e into commercialhaskell:master Aug 30, 2019
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants