Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hspec 2.4 #2229

Closed
1 of 4 tasks
snoyberg opened this issue Jan 24, 2017 · 15 comments
Closed
1 of 4 tasks

hspec 2.4 #2229

snoyberg opened this issue Jan 24, 2017 · 15 comments

Comments

@snoyberg
Copy link
Contributor

snoyberg commented Jan 24, 2017

hspec-2.4.0 (Simon Hengel sol@typeful.net @sol) is out of bounds for:

Updated on February 4

snoyberg added a commit that referenced this issue Jan 24, 2017
snoyberg added a commit that referenced this issue Jan 24, 2017
@NorfairKing
Copy link
Contributor

Fixed for genvalidity-hspec on hackage and for next release.

@mitchellwrosen
Copy link
Contributor

Fixed for tasty-hspec

@sol
Copy link
Contributor

sol commented Jan 25, 2017

Upper bounds for hspec are rarely useful or needed.

That said, there may be a backwards incompatible change regarding hooks (bofere, around, etc.) at some point in the future. But if that happens it will be done in a way so that it affects as few users as possible.

In general I advise not to use upper bounds for hspec, but this is even more true if you

  • only import Test.Hspec
  • don't use hooks

On the other hand if you depend on hspec-core and tinker with all kinds of internals upper bounds might be justified (@mitchellwrosen you do, and you need to modify your code to make it work, your travis is failing right now).

@mitchellwrosen
Copy link
Contributor

Yeah, I saw that. Will fix w/in the next few days assuming the internals haven't changed too much.

@debug-ito
Copy link
Contributor

Fixed for fold-debounce, fold-debounce-conduit, stopwatch, wikicfp-scraper, wild-bind and wild-bind-x11.

OK, I'm gonna drop the upper bounds the next time hspec does major version bump :)

dhess added a commit to dhess/hpio that referenced this issue Jan 26, 2017
@dhess
Copy link
Contributor

dhess commented Jan 26, 2017

Fixed in hpio-0.8.0.6.

snoyberg added a commit that referenced this issue Jan 26, 2017
@decentral1se
Copy link
Member

Fix for lentil has arrived.

@MichelBoucey
Copy link
Contributor

cayley-client and glabrous fixed.

@mitchellwrosen
Copy link
Contributor

tasty-hspec fixed for real this time.

@typedrat
Copy link
Contributor

typedrat commented Jan 26, 2017 via email

@m0rphism
Copy link
Contributor

Fixed in printcess-0.1.0.3.

ajnsit added a commit to ajnsit/wai-routes that referenced this issue Jan 26, 2017
@DanielG
Copy link
Contributor

DanielG commented Jan 26, 2017

Fixed for ghc-mod-5.7.0.0 in rev-1.

@typedrat
Copy link
Contributor

typedrat commented Feb 4, 2017

Fixed with revs for both of my packages.

@DanBurton
Copy link
Contributor

The following test suites have been disabled for the nightly and soon-to-come LTS 8 builds.

@bitemyapp
Copy link
Contributor

bloodhound-0.13.0.0 is released with hspec-2.4.0 compatibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests