Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cryptohash 0.9.0 #54

Closed
snoyberg opened this issue Apr 3, 2013 · 6 comments
Closed

cryptohash 0.9.0 #54

snoyberg opened this issue Apr 3, 2013 · 6 comments

Comments

@snoyberg
Copy link
Contributor

snoyberg commented Apr 3, 2013

diagrams-builder-0.3 (Brent Yorgey byorgey@gmail.com @diagrams) cannot use:

  • cryptohash-0.9.0 -- >=0.7.4 && <0.9

uuid-1.2.9 (Antoine Latter) cannot use:

  • cryptohash-0.9.0 -- >=0.7 && <0.9

Paging @byorgey and @aslatter

snoyberg added a commit that referenced this issue Apr 3, 2013
@aslatter
Copy link
Contributor

aslatter commented Apr 3, 2013

Hi @vincenthz - looking at the commits to cryptohash I don't see any API changes from the 0.8 series. Is that correct?

@byorgey
Copy link
Contributor

byorgey commented Apr 3, 2013

Looks to me like the API didn't change per se, but some parts of the API were deprecated. I for one am glad of the major version bump since otherwise I wouldn't notice that I'm using deprecated stuff.

@byorgey
Copy link
Contributor

byorgey commented Apr 4, 2013

Released diagrams-builder-0.3.0.1.

@aslatter
Copy link
Contributor

aslatter commented Apr 4, 2013

Released uuid-1.2.10.

@snoyberg
Copy link
Contributor Author

snoyberg commented Apr 4, 2013

Thanks guys, closing.

@vincenthz
Copy link
Contributor

Sorry, i'm a bit slow to respond, but there's no API change if you're not using crypto-api. I wasn't sure that it was the proper PvP way, but i've heard people complain when putting a deprecation notice with just a point upgrade. Also i believe the PvP warrant another major upgrade (which i'll probably call 1.0.0) to remove the deprecated stuff and dependency, so if you're not using crypto-api by then (either using cryptohash api directly, or cryptohash-cryptoapi package), i can recommend putting a higher bound preemptively (< 1.1) if you make another release of your respective packages. Cheers !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants