Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revision on hourglass places a lower bound on time than the one we already have #7435

Closed
1 task
mihaimaruseac opened this issue May 26, 2024 · 4 comments
Closed
1 task

Comments

@mihaimaruseac
Copy link
Contributor

Looking at https://hackage.haskell.org/package/hourglass-0.2.12/revisions/ we see that r1 has the following description

Changed the test suite 'test-hourglass' component's library dependency on 'time' from

>=0

to

<1.10

However, we have time-1.12.2 and hourglass-0.2.12 in the snapshot and no bounds issue (though we expect a failure from hourglass).

As a result, we now have

time-1.12.2 (changelog) is out of bounds for:

  • hourglass-0.2.12 (< 1.10). Grandfathered dependencies. Used by: test-suite

To fix this, I'll move hourglass from expected failure section to skipped test.

CC @Bodigrim as the author of the revision, in case a better solution exists.

mihaimaruseac added a commit that referenced this issue May 26, 2024
)

Signed-off-by: Mihai Maruseac <mihai.maruseac@gmail.com>
@Bodigrim
Copy link
Contributor

Same as in other cases, it feels like Stackage tooling does not build tests at all if there is an expected failure.

@alaendle
Copy link
Member

As documented in the YAML

# Tests listed in expected-test-failures configure correctly but may fail to run or even build correctly.

@mihaimaruseac
Copy link
Contributor Author

Probably we should put test build failures into skipped tests instead of expected test failures area.

@mihaimaruseac
Copy link
Contributor Author

Closing as there's not much we can do. The test was already broken.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants