Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added hPDB, hPDB-examples, Octree, FenwickTree. #139

Merged
merged 1 commit into from
Nov 9, 2013
Merged

Added hPDB, hPDB-examples, Octree, FenwickTree. #139

merged 1 commit into from
Nov 9, 2013

Conversation

mgajda
Copy link
Contributor

@mgajda mgajda commented Nov 9, 2013

Dear Stackage Maintainers,

I believe my packages build alright, and would like to include them in your repository.

Best regards
Michal

snoyberg added a commit that referenced this pull request Nov 9, 2013
Added hPDB, hPDB-examples, Octree, FenwickTree.
@snoyberg snoyberg merged commit 00435a7 into commercialhaskell:master Nov 9, 2013
@snoyberg
Copy link
Contributor

There's a problem building hPDB with GHC 7.4.2, since it includes an older version of bytestring:

hPDB-0.9999 (Michal J. Gajda @mgajda) cannot use:

  • bytestring-0.9.2.1 -- >=0.10.0.0

Would it be possible to upload a new version of hPDB which allows bytestring 0.9?

@mgajda
Copy link
Contributor Author

mgajda commented Nov 10, 2013

The flag was already there:
if flag(old-bytestring)
cpp-options: -DDEFINE_NFDATA_INSTANCE
build-depends: bytestring <= 0.9.2.1
else
build-depends: bytestring >= 0.10.0.0

How to add flags to Stackage config? (Most recent cabal-install seems to figure these automatically.)

@mgajda
Copy link
Contributor Author

mgajda commented Nov 10, 2013

Since the library can be built with any GHC from 7.0 up, it has also other build flag: old-zlib, old-vector.
There are also options to remove some dependencies: have-text-format, have-mmap.

@snoyberg
Copy link
Contributor

Is there a reason to put all of this logic into the Cabal file, instead of just using CPP macros in the source files instead? E.g.,

#if MIN_VERSION_bytestring(0, 10, 0)
...
#else
...
#endif

@mgajda
Copy link
Contributor Author

mgajda commented Nov 11, 2013

I could try to do that. But I understand CPP macros work only for Cabal
package versions, don't they?
Do I have to add any special parameter to .cabal, or are these macros

always defined?

Best
Michal

@snoyberg
Copy link
Contributor

They're automatically generated macros, you don't have to do anything
special.

@mgajda
Copy link
Contributor Author

mgajda commented Nov 11, 2013

Dear Michael,

I have just uploaded hPDB 0.9999.1 on Hackage.
New macros as you suggested.
Should fix build issues, please let me know if there are any further

troubles.

Best regards
Michal

@snoyberg
Copy link
Contributor

Thanks! It looks like everything's working properly now, I'll let you know if I run into any issues.

@mgajda
Copy link
Contributor Author

mgajda commented Nov 11, 2013

Thank you. Particularly for taking your time to look at it. After all this
is the point of Stackage for maintainers to fix such build/portability

bugs. Let's hope distro package maintainers pick it up soon.

Michal
On 11 Nov 2013 15:00, "Michael Snoyman" notifications@github.com wrote:

Thanks! It looks like everything's working properly now, I'll let you know
if I run into any issues.


Reply to this email directly or view it on GitHubhttps://github.com//pull/139#issuecomment-28201624
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants