-
Notifications
You must be signed in to change notification settings - Fork 796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rm: allele as a maintainer - not enough time #2239
Conversation
We @IxpertaSolutions use |
If the effect stack is built on top a monad that has MonadReader/MonadState capabilities, then it is easier to evaluate the Reader/State effect directly in terms of base effect. For this purpose we now provide following functions: runReaderAsBase :: forall m effs e a . BaseMember m effs => m e -> Eff (Reader e ': effs) a -> Eff effs a runReaderM :: forall e m effs a . (MonadReader e m, BaseMember m effs) => Eff (Reader e ': effs) a -> Eff effs a runStateAsBase :: forall s m effs a . BaseMember m effs => m s -> (s -> m ()) -> Eff (State s ': effs) a -> Eff effs a runStateM :: forall s m effs a . (MonadState s m, BaseMember m effs) => Eff (State s ': effs) a -> Eff effs a Unfortunately to implement runState{AsBase,M} we need unsafeCoerce, because State effect data constructors aren't exported by freer package.
Understood, thanks for providing the package in Stackage until now. @liskin feel free to send a PR to add the package back under your own name, we always accept Stackage maintainers who are not the original authors. |
@snoyberg Does it make sense to be a Stackage maintainer without being able to upload fixes to hackage? @queertypes Are you ok with adding me and/or my colleagues (if they're up to it) as co-maintainers on hackage or do we need to change the package name? |
Yes, please see the maintainer's agreement: https://github.com/fpco/stackage/blob/master/MAINTAINERS.md |
I don't see how I could "quickly (within 1 week) upload a new version with relaxed version bounds" without being able to upload to hackage? I thought the ability to have locally modified packages was removed from stack (http://www.snoyman.com/blog/2017/01/stackage-design-choices). |
Feel free to ask on the Stackage mailing list about this, there are many
people who fulfill this maintainer role. Worst case scenario, the package
is temporarily dropped while you work with upstream.
…On Sat, Jan 28, 2017 at 6:58 PM, Tomáš Janoušek ***@***.***> wrote:
I don't see how I could "quickly (within 1 week) upload a new version with
relaxed version bounds" without being able to upload to hackage? I thought
the ability to have locally modified packages was removed from stack (
http://www.snoyman.com/blog/2017/01/stackage-design-choices).
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2239 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AADBByuSPBkfFUpbHxAi3a9A2DiTsB90ks5rW3PQgaJpZM4Lwdcq>
.
|
Your worst case scenario assumes the upstream is alive and at least somewhat cooperative. I wish I lived with such worst case scenarios. :-) Anyway, I'll wait for her reply, research the Stackage mailing list and think of something. |
@liskin Hi. Please fork and use another name for your package. I'd like to retain maintainership of my own branch of freer, which may or may not meet your needs, and was created primarily to satisfy my own curiosity. |
@queertypes please correct me if I'm wrong, but you're saying that you can't maintain Or - is it that you don't have enough time to act as maintainer for stackage, while hackage has no such time requirement? (Now I think this is what is going on). |
@schell In summary, here is what I am saying:
|
👍 thanks for the clarification @queertypes |
FYI #2309 |
I'm removing
freer
andwai-request-spec
from stackage. I cannot honor the maintainer agreement between my current available time and funding.Others are welcome to pick up those packages and fork them if they'd like to continue to use them.