Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rm: allele as a maintainer - not enough time #2239

Merged
merged 1 commit into from
Jan 28, 2017

Conversation

queertypes
Copy link
Contributor

I'm removing freer and wai-request-spec from stackage. I cannot honor the maintainer agreement between my current available time and funding.

Others are welcome to pick up those packages and fork them if they'd like to continue to use them.

@liskin
Copy link
Contributor

liskin commented Jan 28, 2017

We @IxpertaSolutions use freer in production and @trskop has been experimenting with some additional stuff in https://github.com/trskop/freer-extra as well. We can fork and continue maintaining it.

liskin referenced this pull request in trskop/freer-effects-extra Jan 28, 2017
If the effect stack is built on top a monad that has
MonadReader/MonadState capabilities, then it is easier to evaluate the
Reader/State effect directly in terms of base effect. For this purpose
we now provide following functions:

  runReaderAsBase
      :: forall m effs e a
      .  BaseMember m effs
      => m e
      -> Eff (Reader e ': effs) a
      -> Eff effs a

  runReaderM
      :: forall e m effs a
      .  (MonadReader e m, BaseMember m effs)
      => Eff (Reader e ': effs) a
      -> Eff effs a

  runStateAsBase
      :: forall s m effs a
      .  BaseMember m effs
      => m s
      -> (s -> m ())
      -> Eff (State s ': effs) a
      -> Eff effs a

  runStateM
      :: forall s m effs a
      .  (MonadState s m, BaseMember m effs)
      => Eff (State s ': effs) a
      -> Eff effs a

Unfortunately to implement runState{AsBase,M} we need unsafeCoerce,
because State effect data constructors aren't exported by freer package.
@snoyberg
Copy link
Contributor

Understood, thanks for providing the package in Stackage until now. @liskin feel free to send a PR to add the package back under your own name, we always accept Stackage maintainers who are not the original authors.

@snoyberg snoyberg merged commit fb7e7fa into commercialhaskell:master Jan 28, 2017
@liskin
Copy link
Contributor

liskin commented Jan 28, 2017

@snoyberg Does it make sense to be a Stackage maintainer without being able to upload fixes to hackage?

@queertypes Are you ok with adding me and/or my colleagues (if they're up to it) as co-maintainers on hackage or do we need to change the package name?

@snoyberg
Copy link
Contributor

Yes, please see the maintainer's agreement: https://github.com/fpco/stackage/blob/master/MAINTAINERS.md

@liskin
Copy link
Contributor

liskin commented Jan 28, 2017

I don't see how I could "quickly (within 1 week) upload a new version with relaxed version bounds" without being able to upload to hackage? I thought the ability to have locally modified packages was removed from stack (http://www.snoyman.com/blog/2017/01/stackage-design-choices).

@snoyberg
Copy link
Contributor

snoyberg commented Jan 28, 2017 via email

@liskin
Copy link
Contributor

liskin commented Jan 28, 2017

Your worst case scenario assumes the upstream is alive and at least somewhat cooperative. I wish I lived with such worst case scenarios. :-)

Anyway, I'll wait for her reply, research the Stackage mailing list and think of something.

@queertypes
Copy link
Contributor Author

@liskin Hi. Please fork and use another name for your package. I'd like to retain maintainership of my own branch of freer, which may or may not meet your needs, and was created primarily to satisfy my own curiosity.

@schell
Copy link
Contributor

schell commented Feb 16, 2017

@queertypes please correct me if I'm wrong, but you're saying that you can't maintain freer and would like others to take over, but that you would like to keep the name freer on hackage?

Or - is it that you don't have enough time to act as maintainer for stackage, while hackage has no such time requirement? (Now I think this is what is going on).

@queertypes
Copy link
Contributor Author

@schell In summary, here is what I am saying:

  • I don't wish for others to take over freer - they're free to fork with a new name
  • I wish to keep the package name freer
  • I cannot keep up with stackage maintainership - I've resigned from that
  • I offer no support or guarantees for the freer package
  • I may push updates to freer on hackage at my own leisure

@queertypes queertypes deleted the rm_allele branch February 16, 2017 22:51
@schell
Copy link
Contributor

schell commented Feb 16, 2017

👍 thanks for the clarification @queertypes

@decentral1se
Copy link
Member

decentral1se commented Feb 17, 2017

FYI #2309

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants