Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-add persistent-mysql-haskell #2956

Merged

Conversation

naushadh
Copy link
Contributor

mysql-haskell is back on stackage, thus making this lib stable again.

@cdornan
Copy link
Contributor

cdornan commented Oct 12, 2017

Indeed, but tls-1.4.0 (Vincent Hanquez @vincenthz) is out of bounds for:

Can you make it work with tls-1.4.0?

@naushadh
Copy link
Contributor Author

naushadh commented Oct 12, 2017 via email

@cdornan
Copy link
Contributor

cdornan commented Oct 13, 2017

Cheers!

@cdornan cdornan merged commit d5e6555 into commercialhaskell:master Oct 13, 2017
@DanBurton
Copy link
Contributor

@naushadh I'm seeing the following build failure on the stackage build server:

Database/Persist/MySQL.hs:1115:3: error:
    parse error on input ‘-- ^ Copy the field directly from the record.’
     |
1115 |   -- ^ Copy the field directly from the record.
     |   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Not sure why this is considered a parse error though...

DanBurton added a commit that referenced this pull request Oct 17, 2017
@naushadh
Copy link
Contributor Author

naushadh commented Oct 17, 2017

@DanBurton I've seen a similar issue before. I can recreate it on stack haddock (haddock does not like data constructor docs below the declaration). I can push a fix and release a new version. However, can the travis job for PRs be updated to catch this?

@DanBurton
Copy link
Contributor

The Travis job only sanity checks version constraints on the build plan. Actually building the packages and docs is done on a separate machine, as it requires more resources.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants