automation: prep for using new bucket #7299
Conversation
No change in behavior if they are unset.
|
lgtm, and seems pretty straight forward.. I could merge and run it; however since I would not consider myself a shell-scripting expert I would ask for another pair of eyes. |
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
| @@ -5,6 +5,12 @@ set -eu +x -o pipefail | |||
| ROOT=$(cd $(dirname $0) ; pwd) | |||
| TARGET=$1 | |||
|
|
|||
| # Home on the container | |||
| : ${C_HOME:=$HOME} | |||
There was a problem hiding this comment.
It has always annoyed me that we have a different path in the container compared to the host.
Though this change seems mostly cosmetic?
There was a problem hiding this comment.
Yes, this just allowed me to override the variable in testing, but doesn't do anything different on its own.
| @@ -146,7 +151,7 @@ docker run $ARGS_UPLOAD $IMAGE /bin/bash -c "exec curator check-target-available | |||
| # | |||
| # * Upload the docs to S3 | |||
| # * Upload the new snapshot .yaml file to the appropriate Github repo, also upload its constraints | |||
| docker run $ARGS_UPLOAD $IMAGE /bin/bash -c "curator upload-docs --target $TARGET && curator upload-github --target $TARGET" | |||
| docker run $ARGS_UPLOAD $IMAGE /bin/bash -c "curator upload-docs --target $TARGET ${DOCS_BUCKET:+--bucket $DOCS_BUCKET}" && curator upload-github --target $TARGET" | |||
There was a problem hiding this comment.
Reverted the PR because in this line the " doesn't match - also I noticed quite strange log messages during running this script mentioning a LTS while I was running a nightly build. Hope this had no unwanted side effects.
There was a problem hiding this comment.
Oops, good catch. Of course I modified this line after running the script locally. You can't write a single line of bash without introducing a bug 😄
There was a problem hiding this comment.
Probably good idea to run it through shellcheck also (not saying you have to fix all the shellcheck warnings).
(Though it doesn't catch the undefined NOPLAN.)
…at/b/new-bucket-prep"" This reverts commit 76a9ef5.
The main substantive change is adding support for AWS_ENDPOINT_URL and setting the name of the bucket for uploading Haddocks (8f8fc12). But I also updated
curatorto a version that supports the--bucketoption and included one change I used while testing the script.