Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

network-run-0.3 and http2-5.2.3 #7454

Merged
merged 2 commits into from
Jul 4, 2024

Conversation

ysangkok
Copy link
Contributor

@ysangkok ysangkok commented Jun 18, 2024

Checklist:

  • Meaningful commit message, eg add my-cool-package (please don't mention build-constraints.yml)
  • At least 30 minutes have passed since uploading to Hackage
  • If applicable, required system libraries are added to 02-apt-get-install.sh or 03-custom-install.sh
  • (recommended) Package have been verified to work with the latest nightly snapshot, e.g by running the verify-package script
  • (optional) Package is compatible with the latest version of all dependencies (Run cabal update && cabal outdated)
    Had to disable attoparsec-framer. But many packages use http2, so I thought it is worth it.

Fixes #7448 and #7444

@ysangkok
Copy link
Contributor Author

@adetokunbo if you relaxed the QuickCheck bound, attoparsec-framer could stay enabled...

@ysangkok ysangkok mentioned this pull request Jun 18, 2024
1 task
@ysangkok ysangkok mentioned this pull request Jun 28, 2024
5 tasks
@ysangkok ysangkok changed the title network-run-0.3 and http-5.2.3, disable attoparsec-framer network-run-0.3 and http2-5.2.3, disable attoparsec-framer Jun 29, 2024
@adetokunbo
Copy link
Contributor

disabling attoparsec-framer should no longer be necessary as of adetokunbo/attoparsec-framer#31

@ysangkok ysangkok changed the title network-run-0.3 and http2-5.2.3, disable attoparsec-framer network-run-0.3 and http2-5.2.3 Jul 1, 2024
@ysangkok
Copy link
Contributor Author

ysangkok commented Jul 2, 2024

pinch isn't proactively being maintained any more, so I think it is fine to disable its test suite:

@juhp juhp merged commit f561fbc into commercialhaskell:master Jul 4, 2024
1 check passed
@juhp
Copy link
Contributor

juhp commented Jul 4, 2024

Thank you, merged!

@ysangkok ysangkok deleted the http-network-run-bump branch July 4, 2024 12:36
@ysangkok ysangkok mentioned this pull request Jul 5, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

http2 5.2.3
3 participants