refactor: Use format strings

Co-authored-by: Wei Lee <weilee.rx@gmail.com>

commitizen/changelog_formats/asciidoc.py

@@ -27,9 +27,9 @@ def parse_version_from_title(self, line: str) -> str | None:
             return None
 
         if partial_matches.get("prerelease"):
-            partial_version += f"-{partial_matches['prerelease']}"
+            partial_version = f"{partial_version}-{partial_matches['prerelease']}"
         if partial_matches.get("devrelease"):
-            partial_version += f"{partial_matches['devrelease']}"
+            partial_version = f"{partial_version}{partial_matches['devrelease']}"
         return partial_version
 
     def parse_title_level(self, line: str) -> int | None:

commitizen/changelog_formats/markdown.py

@@ -30,9 +30,9 @@ def parse_version_from_title(self, line: str) -> str | None:
             return None
 
         if matches.get("prerelease"):
-            partial_version += f"-{matches['prerelease']}"
+            partial_version = f"{partial_version}-{matches['prerelease']}"
         if matches.get("devrelease"):
-            partial_version += f"{matches['devrelease']}"
+            partial_version = f"{partial_version}{matches['devrelease']}"
         return partial_version
 
     def parse_title_level(self, line: str) -> int | None:

commitizen/changelog_formats/restructuredtext.py

@@ -77,9 +77,13 @@ def get_metadata_from_file(self, file: IO[Any]) -> Metadata:
                             f"{matches['major']}.{matches['minor']}.{matches['patch']}"
                         )
                         if matches.get("prerelease"):
-                            partial_version += f"-{matches['prerelease']}"
+                            partial_version = (
+                                f"{partial_version}-{matches['prerelease']}"
+                            )
                         if matches.get("devrelease"):
-                            partial_version += f"{matches['devrelease']}"
+                            partial_version = (
+                                f"{partial_version}{matches['devrelease']}"
+                            )
                         meta.latest_version = partial_version
                         meta.latest_version_position = index
                         break

commitizen/changelog_formats/textile.py

@@ -19,17 +19,20 @@ def parse_version_from_title(self, line: str) -> str | None:
         if "version" in m.groupdict():
             return m.group("version")
         matches = m.groupdict()
-        try:
-            partial_version = (
-                f"{matches['major']}.{matches['minor']}.{matches['patch']}"
-            )
-        except KeyError:
+        if not all(
+            [
+                version_segment in matches
+                for version_segment in ("major", "minor", "patch")
+            ]
+        ):
             return None
 
+        partial_version = f"{matches['major']}.{matches['minor']}.{matches['patch']}"
+
         if matches.get("prerelease"):
-            partial_version += f"-{matches['prerelease']}"
+            partial_version = f"{partial_version}-{matches['prerelease']}"
         if matches.get("devrelease"):
-            partial_version += f"{matches['devrelease']}"
+            partial_version = f"{partial_version}{matches['devrelease']}"
         return partial_version
 
     def parse_title_level(self, line: str) -> int | None:

commitizen/defaults.py

@@ -135,7 +135,9 @@ class Settings(TypedDict, total=False):
 bump_message = "bump: version $current_version → $new_version"
 
 
-def get_tag_regexes(version_regex: str) -> dict[str | Any, str | Any]:
+def get_tag_regexes(
+    version_regex: str,
+) -> dict[str, str]:
     return {
         "$version": version_regex,
         "$major": r"(?P<major>\d+)",