Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V3.x #453

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from
Draft

V3.x #453

wants to merge 6 commits into from

Conversation

saketjajoo
Copy link

No description provided.

LinusU and others added 6 commits January 8, 2017 20:46
Use the execa library when invoing git
On my system `stdout` was undeifned and resulted in "Cannot read property 'trim' of undefined".
Switching this code to also use execa fixes that issue.
BREAKING CHANGE: Node.js 0.12 is no longer supported
…416)

Adapters should depend directly on inquirer instead of using the one provided by us.
BREAKING CHANGE: czConfig is no longer read for config
This replaces ghooks with husky. ghooks is deprecated in favor of husky. Contributors may need to

For commitizen developers, you need to do the following:

1. rm -rf .git/hooks
2. rm -rf node_modules
3. run npm install.

Closes #410
@jimthedev
Copy link
Member

Hey there. Thanks for doing this! Can you update the conflicts?

@jimthedev
Copy link
Member

cc @saketjajoo

@nshtg
Copy link

nshtg commented Nov 9, 2017

Since this is a new major release, maybe consider upgrading the ancient inquirer version?

Also I remember reading thoughts about letting The adapter supply their own version of inquirer (this would greatly reduce the risk of breaking in the feature)?

One could consider dropping support for non LTS/current versions aswell and start using features like package-lock.json or yarn.lock for better stability.

@dmwelch
Copy link
Contributor

dmwelch commented Aug 25, 2020

This PR is so old. I'm converting it to a draft until someone has time to look at it and see if it is still valid.

@dmwelch dmwelch marked this pull request as draft August 25, 2020 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants