add api endpoints #281
add api endpoints #281
Conversation
chrisbutler
force-pushed
the
api-endpoints
branch
from
9e260bf
to
12f3410
Compare
Codecov Report
@@ Coverage Diff @@
## master #281 +/- ##
=========================================
- Coverage 21.06% 20.17% -0.9%
=========================================
Files 28 31 +3
Lines 674 704 +30
=========================================
Hits 142 142
- Misses 532 562 +30
Continue to review full report at Codecov.
|
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
app/api.js
Outdated
| @@ -34,11 +35,55 @@ app.get('/users/create/:username', (req, res) => { | |||
| } | |||
| }) | |||
|
|
|||
| app.post('/promises/parse/', (req, res) => { | |||
| const { | |||
There was a problem hiding this comment.
Identical blocks of code found in 2 locations. Consider refactoring.
app/api.js
Outdated
| // TODO implement a /create POST endpoint | ||
| // app.post('/promises/create/', (req, resp) => {}) | ||
| app.post('/_s/:user/promises/create/', (req, res) => { | ||
| const { |
There was a problem hiding this comment.
Identical blocks of code found in 2 locations. Consider refactoring.
app/api.js
Outdated
| import actionNotifier from '../lib/notify' | ||
| import parseCredit from '../lib/parse/credit' | ||
| import { seed, importJson } from '../db/seed' | ||
| import cache from '../db/cache' | ||
|
|
||
| // TODO: https://github.com/Vincit/objection.js/tree/master/examples/express-ts |
|
Code Climate has analyzed commit 1abf1f7 and detected 8 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 0.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 20.1% (-0.8% change). View more on Code Climate. |
| const api = Router() | ||
|
|
||
| api.post('/promises/parse/', (req, res) => { | ||
| const { |
There was a problem hiding this comment.
Identical blocks of code found in 2 locations. Consider refactoring.
| }) | ||
|
|
||
| api.post('/promises/create/', (req, res) => { | ||
| const { |
There was a problem hiding this comment.
Identical blocks of code found in 2 locations. Consider refactoring.
| import PromiseApi from '../api/v1/promises' | ||
| import UserApi from '../api/v1/users' | ||
|
|
||
| // TODO: https://github.com/Vincit/objection.js/tree/master/examples/express-ts |
http://api.commits.to/docs