Allow filtering by multiple space-separated tokens #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexjurkiewicz
force-pushed
the
better-profile-filtering
branch
from
cc6cfca
to
7cc5241
Compare
I use profile names of the form `product_env_rolename_region`, so it's often useful to search for something like "dev us-east-1". Since spaces aren't allowed in profile names, this should be completely backwards-compatible.
alexjurkiewicz
force-pushed
the
better-profile-filtering
branch
from
7cc5241
to
5154e90
Compare
|
🙌 just tested this and found it extremely user friendly. Thanks so much for the contribution @alexjurkiewicz! |
chrnorm
approved these changes
Aug 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I use profile names of the form
product_env_rolename_region, so it'soften useful to search for something like "dev us-east-1". Since spaces
aren't allowed in profile names, this should be completely
backwards-compatible.