fix assume output for setting up SSO ENV VARS #545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meyerjrr
requested changes
Nov 7, 2023
JoshuaWilkes
deleted the
fix-#539-active-role-flag-not-working-for-sso-profiles
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Fixes #539
When we made the breaking change to no longer export credentials for SSO profiles with credential process configured, there was a misconfiguration with the outputs which caused the special env var GRANTED_SSO to be set to "true"
This ENV var is used in conjunction with the --sso flags so that Granted knows that the profile doesn't exist in the config file but that it can reconstruct it virtually to reassume it.
Why?
How did you test it?
Potential risks
Is patch release candidate?
Link to relevant docs PRs