馃悰 Fix SSO token lookup keys #565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The lookup key for `GetValidSSOToken` has been updated and the code I pushed had the wrong lookup causing panic when trying to export sso as it was finding a `nil` token. Updated `GetValidSSOToken` to use the combination of `SSOStartURL` and `SSOSessionName` to find it properly. Also updated `GetValidSSOTokenFromPlaintextCache` to only use `SSOStartURL` as it's the valid value. Should move to use `SSOSessionName` in the future. Fix for issue common-fate#563.
Updated comment to also include SSOSessionName on the description.
shwethaumashanker
approved these changes
Dec 16, 2023
shwethaumashanker
approved these changes
Dec 16, 2023
sosheskaz
pushed a commit
to sosheskaz/granted
that referenced
this pull request
Dec 19, 2023
* 馃悰 Fix SSO token lookup keys The lookup key for `GetValidSSOToken` has been updated and the code I pushed had the wrong lookup causing panic when trying to export sso as it was finding a `nil` token. Updated `GetValidSSOToken` to use the combination of `SSOStartURL` and `SSOSessionName` to find it properly. Also updated `GetValidSSOTokenFromPlaintextCache` to only use `SSOStartURL` as it's the valid value. Should move to use `SSOSessionName` in the future. Fix for issue common-fate#563. * Update comment Updated comment to also include SSOSessionName on the description.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Updated
GetValidSSOTokento use a combination ofSSOStartURLandSSOSessionNameandGetValidSSOTokenFromPlaintextCacheto useSSOStartURLfor lookup keysWhy?
The lookup key for
GetValidSSOTokenhas been updated and the code I pushed had the wrong lookup causing panic when trying to export sso as it was finding aniltoken. UpdatedGetValidSSOTokento use the combination ofSSOStartURLandSSOSessionNameto find it properly. Also updatedGetValidSSOTokenFromPlaintextCacheto only useSSOStartURLas it's the valid value. Should move to useSSOSessionNamein the future. Fix for issue #563.How did you test it?
Potential risks
Is patch release candidate?
Link to relevant docs PRs