Fix export lookup values when exporting credentials #578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When `session` is present on the config it should be where we get the `start_url` and `region`. Most configs will not have said config under `profile` if they have a session block. Session block takes priority for the configuration as it's considered as it's connecting profiles together. Fix for common-fate#577
Override the sso_start_url if it's empty and have a proper session block.
cedieio
commented
Dec 20, 2023
| @@ -32,12 +32,22 @@ type SSOPlainTextOut struct { | |||
| // we'll allow users to export a plaintext token from their keychain for compatibility | |||
| // purposes with other AWS tools. | |||
| func CreatePlainTextSSO(awsConfig config.SharedConfig, token *securestorage.SSOToken) *SSOPlainTextOut { | |||
| ssoRegion := awsConfig.SSORegion | |||
| if ssoRegion == "" && awsConfig.SSOSession != nil { | |||
There was a problem hiding this comment.
Was originally
if awsConfig.SSOSession != nil {
ssoRegion = awsConfig.SSOSession.SSORegion
ssoStartURL = awsConfig.SSOSession.SSOStartURL
}
Changed as profile can still have URLs set and the config still uses that
shwethaumashanker
approved these changes
Dec 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
When
sessionis present on the config it should be where we get thestart_urlandregion. Most configs will not have said config underprofileif they have a session block. Session block takes priority for the configuration as it's considered as it's connecting profiles together.Fix for #577
Why?
Although it's working properly for
awsclithe generated token does not containsso_start_urlwhich could be problematic for other code that relies on that property when looking for a valid config.How did you test it?
dassume --export-sso-tokencat
~/.aws/sso/cache/<corresponding json>should give outPotential risks
Is patch release candidate?
Link to relevant docs PRs