Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete former credentials when rotating (granted credentials rotate) #582

Merged
merged 2 commits into from Mar 1, 2024

Conversation

n3s7or
Copy link
Contributor

@n3s7or n3s7or commented Dec 22, 2023

What changed?

Added code to delete old credentials.

Why?

How did you test it?

I rotated my own AWS credentials

Potential risks

Is patch release candidate?

No

Link to relevant docs PRs

Copy link
Contributor

@chrnorm chrnorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thankyou @n3s7or!!

Copy link
Contributor

@chrnorm chrnorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, just looking through the PR and original issue #388 and it would be good to introduce this as opt-in behaviour. Could you please add a flag --delete to the command, and then only delete the key if the flag is set?

You can do so by adding

&cli.BoolFlag{Name: "delete", Usage: "delete the previous active key"}

to the command definition and then using

if c.Bool("delete") { }

to check if the flag is set.

@n3s7or
Copy link
Contributor Author

n3s7or commented Jan 25, 2024

Thanks for your input @chrnorm
The change is done :)

Copy link
Contributor

@chrnorm chrnorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌 thankyou @n3s7or!

@chrnorm chrnorm merged commit 8847355 into common-fate:main Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants