feat: Use aws:username for IAM initiated federated console sessions. #626
+112
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The changes refactor the way federation token ID is used for AWS IAM credentials. Instead of relying on the userID which was previously parsed, the code now uses the userName which is more easily attributable to the IAM user name in the Cloudtrail events list view. In the Cloudtrail console's event history view, the IAM user name will now display in the `user name` column. Previously, the `user id` would display (e.g. AIDA.....). Signed-off-by: Matthew Hembree <47449406+matthewhembree@users.noreply.github.com>
chrnorm
approved these changes
Mar 29, 2024
There was a problem hiding this comment.
🙌 Thanks very much and congratulations here on your first contribution to Granted @matthewhembree! This looks great, I've added an additional unit test around the behaviour here 3e5ea5f
|
Thank you @chrnorm! I wondered about tests.. they're my blind spot. Your code was very educational!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Closes #625
The changes refactor the way federation token ID is used for AWS IAM credentials. Instead of relying on the userID which was previously parsed, the code now uses the userName which is more easily attributable to the IAM user name in the Cloudtrail events list view.
Old:
New:
Why?
In the Cloudtrail console's event history view, the IAM user name will now display in the
user namecolumn. Previously, theuser idwould display (e.g. AIDA.....).How did you test it?
granted credentials add.assume -c.Potential risks
Is patch release candidate?
Link to relevant docs PRs