add a check for empty access key ID when caching #632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prevents an issue where if the granted credential-process returned an empty JSON, Granted would cache it and require manually clearing the cache.
meyerjrr
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
adds a check to prevent caching credentials if the access key is empty
Why?
prevents an issue where if the granted credential-process returned an empty JSON, Granted would cache it and require manually clearing the cache.
How did you test it?
testing the granted credential-process integration. To reproduce, add a credential process which returns a JSON with an empty access key ID. The previous behaviour is that Granted will cache this, which causes the AWS CLI to stop working.
Potential risks
Low risk as the access key should never be empty.
Is patch release candidate?
Yes
Link to relevant docs PRs