Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump awsconfigfile #648

Merged
merged 3 commits into from
May 3, 2024
Merged

bump awsconfigfile #648

merged 3 commits into from
May 3, 2024

Conversation

mikesarver
Copy link
Contributor

What changed?

Bump awsconfigfile dependency

Why?

Add Sprig Template functions for SectionNameTemplate to allow consistent profile names. (lower case and delimiter instead of spaces)

How did you test it?

Go test

Potential risks

Is patch release candidate?

Link to relevant docs PRs

@ibottamike
Copy link
Contributor

ibottamike commented May 1, 2024

I'm debugging issue when testing locally

./bin/dgranted sso generate --sso-region us-east-1 --profile-template "{{ replace ` ` `-` .AccountName }}/{{ .RoleName }}" https://yourid.awsapps.com/start
[✘] template: :1: unexpected "~" in operand`  

@mikesarver
Copy link
Contributor Author

I'm debugging issue when testing locally

./bin/dgranted sso generate --sso-region us-east-1 --profile-template "{{ replace ` ` `-` .AccountName }}/{{ .RoleName }}" https://yourid.awsapps.com/start
[✘] template: :1: unexpected "~" in operand`  

I see the default behavior is to replace space with -, so that is not required (and not a sprig function).
The following command works.

./bin/dgranted sso generate --sso-region us-east-1 --profile-template "{{ .AccountName | lower }}/{{ .RoleName }}" https://yourid.awsapps.com/start

@chrnorm
Copy link
Contributor

chrnorm commented May 3, 2024

Thanks @mikesarver!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants