Skip to content
This repository has been archived by the owner on May 10, 2023. It is now read-only.

Add page. Explain when possible why each sentence has been rejected. #43

Closed
Txopi opened this issue Jan 2, 2019 · 5 comments
Closed
Assignees
Milestone

Comments

@Txopi
Copy link

Txopi commented Jan 2, 2019

I added 60 sentences in Basque language and this one has been rejected: "Amerikar Estatu Batuak AEB bezala laburtzen dira." (it means something like "United States of America is shorted as USA.")

They are too many uppercase words? The problem is with the acronym? Too many words? The interface give no explanation so I don't know how to reformulate the sentence.

I understand that some regular expressions used in the source code don't have an easy explanation, but other do have (or should have). I think it deserves to make an effort and try to give a reason (at least one) why each sentence has been rejected:

  • More than 10 words are not allowed
  • Acronyms are not allowed
  • ...

NOTE: while adding the sentences, the "Confirm" button should be disabled and the interface should say what's happening, because if they are many sentences or the server is busy, this process can take long (and users tend to click and double click all the buttons if you don't give feedback all the time...) .

@MichaelKohler MichaelKohler added the enhancement New feature or request label Jan 2, 2019
@MichaelKohler
Copy link
Member

Do you think it would help for now if we linked to https://common-voice.github.io/sentence-collector/#/how-to ?

Longer term, giving exact reasons sounds reasonable.

@nukeador
Copy link

nukeador commented Jan 2, 2019

Let's include a link to that page in a way it doesn't take a lot of space or distracts the workflow.

@Txopi
Copy link
Author

Txopi commented Jan 2, 2019

For the moment, it would help to link that page, but giving the exact reason next to each sentence would be really helpful for many users.

NOTE: I saw that filtered sentences are added anyway (like the one in the example above). That's what we want? That's not a list of errors, just a list of warnings?

@MichaelKohler
Copy link
Member

I've created a PR to add the link to the rejection list.

NOTE: I saw that filtered sentences are added anyway (like the one in the example above). That's what we want? That's not a list of errors, just a list of warnings?

Oh no, this is a huge bug. I've filed an issue to track this: #51

@MichaelKohler MichaelKohler removed this from the MVP milestone Jan 2, 2019
MichaelKohler added a commit that referenced this issue Jan 3, 2019
Add link to guidelines for rejected sentences (issue #43)
@MichaelKohler MichaelKohler added this to Selected Backlog in Project Jan 7, 2019
@MichaelKohler MichaelKohler added this to the February 2019 milestone Jan 25, 2019
@MichaelKohler MichaelKohler self-assigned this Feb 24, 2019
MichaelKohler added a commit that referenced this issue Feb 24, 2019
…explanation

feat: list explanation why sentence was invalid (fixes #43)
@MichaelKohler MichaelKohler moved this from Selected Backlog to Done in Project Feb 24, 2019
MichaelKohler pushed a commit that referenced this issue Feb 24, 2019
# [1.7.0](v1.6.0...v1.7.0) (2019-02-24)

### Features

* add sah language ([e059b9e](e059b9e))
* list explanation why sentence was invalid (fixes [#43](#43)) ([8a82a74](8a82a74))
@MichaelKohler
Copy link
Member

🎉 This issue has been resolved in version 1.7.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants