Skip to content
This repository has been archived by the owner on May 10, 2023. It is now read-only.

Filtered (invalid) sentences get submitted anyway #51

Closed
MichaelKohler opened this issue Jan 2, 2019 · 1 comment
Closed

Filtered (invalid) sentences get submitted anyway #51

MichaelKohler opened this issue Jan 2, 2019 · 1 comment
Assignees
@MichaelKohler
Labels
bug Something isn't working frontend
Milestone
MVP

Comments

@MichaelKohler
Copy link
Member

From #43 (comment):

NOTE: I saw that filtered sentences are added anyway (like the one in the example above). That's what we want? That's not a list of errors, just a list of warnings?

This is bad. Those should not be submitted!
@MichaelKohler MichaelKohler added the bug Something isn't working label Jan 2, 2019
@MichaelKohler MichaelKohler added this to the MVP milestone Jan 2, 2019
@MichaelKohler MichaelKohler self-assigned this Jan 2, 2019
@MichaelKohler MichaelKohler mentioned this issue Jan 2, 2019
Closed
MichaelKohler added a commit that referenced this issue Jan 3, 2019
@MichaelKohler
Merge pull request #57 from MichaelKohler/feature/filtered_sentences_…
cd60e68 
…not_submit

Correctly filter out failed validation (fixes #51)
@MichaelKohler
Copy link
Member Author

🎉 This issue has been resolved in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@MichaelKohler MichaelKohler

Labels
bug Something isn't working frontend
Projects
None yet
Milestone
MVP
Development

No branches or pull requests
1 participant
@MichaelKohler