Skip to content
This repository has been archived by the owner on May 10, 2023. It is now read-only.

Fix to eo.js and tok.js validation scripts #616

Merged
merged 2 commits into from
Mar 27, 2022
Merged

Fix to eo.js and tok.js validation scripts #616

merged 2 commits into from
Mar 27, 2022

Conversation

janPensa
Copy link
Contributor

Somehow [BbCcDdFfGgHhQqRrVvXxYyZz\u00C0-\u02BF\u1E00-\u1EFF\uF1900-\uF19FF] and [qQwWxXyYÀ-ćĊ-ěĞ-ģĞ-ģĦ-ijĶ-śŞ-ūŮ-\u02AF\u1E00-\u1EFFα-ωΑ-ΩЀ-ӿ] match with all regular Latin letters as well, making the Sentence Collector reject all submissions.

Changed to [BbCcDdFfGgHhQqRrVvXxYyZzÀ-ʯḀ-ỿ] and [qQwWxXyYÀ-ćĊ-ěĞ-ģĞ-ģĦ-ijĶ-śŞ-ūŮ-ʯḀ-ỿα-ωΑ-ΩЀ-ӿ], which should work well. (At least they do in Notepad++, which I found has the same behavior.)

@janPensa janPensa mentioned this pull request Mar 27, 2022
Merged
MichaelKohler
MichaelKohler approved these changes Mar 27, 2022
View reviewed changes
Copy link
Member

@MichaelKohler MichaelKohler left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once merged it will automatically be deployed to the staging instance at https://commonvoice.allizom.org/sentence-collector. This might take about 20 minutes. Can you verify the fix there and if all good, I will run a deployment to production. Thanks!

@MichaelKohler MichaelKohler merged commit e25b8f2 into common-voice:main Mar 27, 2022
@MichaelKohler
Copy link
Member

@janPensa tested on https://commonvoice.allizom.org/sentence-collector, looks good to me. Would you agree?

@janPensa
Copy link
Contributor Author

@MichaelKohler It seems like https://commonvoice.allizom.org/sentence-collector uses the old validation script. It rejects sentences longer than 14 words, and doesn't reject invalid words that don't follow phonotactics.

@MichaelKohler
Copy link
Member

Yeah, looks like something is off with that deployment. I'll deploy to production now then.

MichaelKohler pushed a commit that referenced this pull request Mar 27, 2022
@semantic-release-bot
chore(release): 2.17.3
0ea776c 
## [2.17.3](v2.17.2...v2.17.3) (2022-03-27)

### Bug Fixes

* fix eo and tok validation regex ([#616](#616)) ([e25b8f2](e25b8f2))
* remove some tok sentences ([3f52314](3f52314))
@MichaelKohler
Copy link
Member

🎉 This PR is included in version 2.17.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@janPensa
Copy link
Contributor Author

Okay. I'll wait a bit and test on commonvoice.mozilla.org

@janPensa
Copy link
Contributor Author

@MichaelKohler I did a few different tests. Looks like everything works as intended now!

@janPensa janPensa deleted the patch-1 branch March 27, 2022 16:03
@MichaelKohler
Copy link
Member

@janPensa should be deployed now :)

@MichaelKohler
Copy link
Member

@janPensa hah, you were faster than me. Thanks for the verification and the hotfix!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MichaelKohler MichaelKohler MichaelKohler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@janPensa @MichaelKohler