Fix spurious validation error with scatter+conditionals #1640
Conversation
Typing related to conditionals should be part of the computed output signature of the step, not added in by the checker. Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>
tetron
changed the title
Codecov Report
@@ Coverage Diff @@
## main #1640 +/- ##
==========================================
- Coverage 66.82% 66.79% -0.03%
==========================================
Files 93 93
Lines 16578 16578
Branches 4404 4404
==========================================
- Hits 11078 11074 -4
- Misses 4361 4364 +3
- Partials 1139 1140 +1
Continue to review full report at Codecov.
|
|
This pull request introduces 1 alert when merging c4442a8 into 0f70992 - view on LGTM.com new alerts:
|
|
This pull request introduces 1 alert when merging 21da544 into 0f70992 - view on LGTM.com new alerts:
|
| for oparam in outputparms: | ||
| if conditional and n == 0: | ||
| oparam["type"] = ["null"] + cast( |
There was a problem hiding this comment.
Can you add a test case that triggers this line?
There was a problem hiding this comment.
Yes, I was going to add a test, I just wanted to see what the other code checks had to say about it.
Typing related to conditionals should be part of the computed output
signature of the step, not added in by the checker.
refs #1639