-
-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Message about using --parallel, and how other CWL runners are available. #1671
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1671 +/- ##
==========================================
+ Coverage 66.86% 66.87% +0.01%
==========================================
Files 93 93
Lines 16648 16664 +16
Branches 4420 4422 +2
==========================================
+ Hits 11131 11144 +13
- Misses 4376 4378 +2
- Partials 1141 1142 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comment about the text about other runners, but I liked the idea of telling users about other runners. +1 for the parallel/serial message too.
@@ -203,6 +212,10 @@ def run_jobs( | |||
runtime_context: RuntimeContext, | |||
) -> None: | |||
|
|||
_logger.info( | |||
"Using default serial job executor. Use `cwltool --parallel` to run multiple steps at a time." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
_logger.info( | ||
"CWL workflows are portable and run on many commercial and open source platforms." | ||
) | ||
_logger.info("Visit https://www.commonwl.org/implementations/ to learn more.") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe shorten it a bit? Perhaps dropping the first line, leaving just the part about "CWL workflows are portable and run .... Visit https:///...".
Argh, sorry, didn't notice the auto-merger was on here 😥 |
@mr-c big ops from me here. I can't see the button to un-do the merge. Could you do it, or should I send a new PR reverting it? Sorry about the mess! |
Or if you have access to that button, @tetron 🙏 |
…le. (#1671) Add message about using --parallel, and how other CWL runners are available.
Was having a discussion about how some people have trouble distinguishing between the capabilities of
cwltool
and the broader CWL ecosystem. It occurred to me that we could just tell people, clearly, to look elsewhere (and where to look).Also added a message about the existence of the
--parallel
option.