URL.build - port can be ""

fix aio-libs#883
commonism · Nov 21, 2023 · 2f95816 · 2f95816
1 parent 8aff6a7
commit 2f95816
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 0 deletions.
diff --git a/CHANGES/883.bugfix b/CHANGES/883.bugfix
@@ -0,0 +1 @@
+Fix URL.build with port="" creating invalid URLs
diff --git a/tests/test_url_build.py b/tests/test_url_build.py
@@ -39,6 +39,9 @@ def test_build_with_port():
     u = URL.build(scheme="http", host="127.0.0.1", port=8000)
     assert str(u) == "http://127.0.0.1:8000"
 
+    u = URL.build(scheme="http", host="127.0.0.1", port="", path="/v1")
+    assert str(u) == "http://127.0.0.1/v1", str(u)
+
 
 def test_build_with_user():
     u = URL.build(scheme="http", host="127.0.0.1", user="foo")

diff --git a/yarl/_url.py b/yarl/_url.py
@@ -233,6 +233,8 @@ def build(
             raise ValueError(
                 'Can\'t mix "authority" with "user", "password", "host" or "port".'
             )
+        if isinstance(port, str) and port == "":
+            port = None
         if port and not host:
             raise ValueError('Can\'t build URL with "port" but without "host".')
         if query and query_string: