New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
regression in URL.build(…,port="") #883
Labels
Comments
commonism
added a commit
to commonism/aiopenapi3
that referenced
this issue
Jun 7, 2023
workaround for aio-libs/yarl#883
commonism
added a commit
to commonism/aiopenapi3
that referenced
this issue
Jun 8, 2023
workaround for aio-libs/yarl#883
commonism
added a commit
to commonism/aiopenapi3
that referenced
this issue
Jun 22, 2023
workaround for aio-libs/yarl#883
commonism
added a commit
to commonism/aiopenapi3
that referenced
this issue
Jul 13, 2023
workaround for aio-libs/yarl#883
commonism
added a commit
to commonism/aiopenapi3
that referenced
this issue
Jul 13, 2023
workaround for aio-libs/yarl#883
commonism
added a commit
to commonism/aiopenapi3
that referenced
this issue
Aug 8, 2023
workaround for aio-libs/yarl#883
Hello, please contribute regression tests via PR to move things along. |
commonism
added a commit
to commonism/yarl
that referenced
this issue
Nov 21, 2023
commonism
added a commit
to commonism/yarl
that referenced
this issue
Nov 21, 2023
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
Input filtering for with_port #793 changed the logic to render the URL to compare the port to None.
94b8679#r116844287
as it is possible to create a URL with a port="" via URL.build, this results in urls created with an empty port.
To Reproduce
Expected behavior
Filtering port="" in URL.build.
I'd even prefer to allow "" and convert to None to stay backwards compatible.
Logs/tracebacks
Python Version
multidict Version
yarl Version
OS
Linux
Additional context
No response
Code of Conduct
The text was updated successfully, but these errors were encountered: