Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

> 32 nested balanced parens in a link is bananas #217

Merged
merged 1 commit into from
Nov 5, 2017
Merged

> 32 nested balanced parens in a link is bananas #217

merged 1 commit into from
Nov 5, 2017

Conversation

kivikakk
Copy link
Contributor

@kivikakk kivikakk commented Jul 12, 2017 •
edited
Loading

Fixes #214 in this fork.

(This is what #216 should have been.)

/cc @mity @vmg

@jgm
Copy link
Member

jgm commented Jul 13, 2017

Technically, this is inconsistent with the spec:

Any number parentheses are allowed without escaping, as long as they are balanced

I suppose we should say in the spec that there's a limit? Or at least that implementations may impose one?

@kivikakk
Copy link
Contributor Author

I think "implementations may impose a limit" is fine.

@jgm jgm merged commit c739195 into commonmark:master Nov 5, 2017
@kivikakk kivikakk deleted the upstream/limit-nested-parens branch November 5, 2017 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kivikakk @jgm