Don't raise exception on invalid UTF-8 output #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This could be reproduced with:
./test/spec_tests.py --program kramdown --pattern Enti
with Kramdown version 1.5.0.
The main problem is that it would stop future tests from being carried out.
After this commit it is just counted as a failure.
The error message printed is of the form:
Unicode error: 'utf8' codec can't decode byte 0xfc in position 8: invalid start byte
'<p># \xd3\x92 \xcf\xa0 \xef\xbf\xbd</p>\n'
'<p># \xd3\x92 \xcf\xa0 \xfc\x85\xb8\xb0\xa9\xb8</p>\n'
jgm
added a commit
that referenced
this pull request
Dec 23, 2014
Don't raise exception on invalid UTF-8 output
jgm
added a commit
that referenced
this pull request
Dec 23, 2014
Indicate which is expected and which is actual output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This could be reproduced with:
with Kramdown version 1.5.0.
The main problem is that it would stop future tests from being carried out.
After this commit it is just counted as a failure.
The error message printed is of the form: