Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add re-center button to Nearby map (in feature branch) #1228

Closed
misaochan opened this issue Feb 28, 2018 · 4 comments
Closed

Add re-center button to Nearby map (in feature branch) #1228

misaochan opened this issue Feb 28, 2018 · 4 comments

Comments

@misaochan
Copy link
Member

misaochan commented Feb 28, 2018

After testing the Nearby feature in directNearbyUploads branch for a bit, I really think that we need to provide a way for users to re-center the map on their current location. Users will be swiping a lot to switch between the list and the map - and if they swipe wrongly and move the map away, they have to reload Nearby or manually go back to their location.

I do recall that we discussed this somewhere else and it was mentioned that the Material guidelines recommend not having more than 1 FAB in the screen. However, I think that a small re-center icon on the upper right would not be amiss, especially given that our other FAB is actually in the bottom sheet and not on the map itself. For reference, Google Maps also uses 3 FABs, 1 of which is the re-center button.

Thoughts?

@Jatin0312
Copy link
Contributor

Jatin0312 commented Feb 28, 2018

Ya I agree there should be re-center button as it is quite frustrating to scroll the map everytime.

@misaochan
Copy link
Member Author

Thanks for the feedback, guys. :) If anyone is interested in implementing this, please remember to work from (and submit the PR to) the directNearbyUploads feature branch, and not master.

@Jatin0312
Copy link
Contributor

I would like to work on this issue. Thanks :)

@neslihanturan
Copy link
Collaborator

Solved.

maskaravivek pushed a commit to maskaravivek/apps-android-commons that referenced this issue Mar 21, 2018
maskaravivek pushed a commit to maskaravivek/apps-android-commons that referenced this issue Mar 21, 2018
maskaravivek pushed a commit that referenced this issue Mar 21, 2018
Fixes issues #1228 added recenter button to nearby map
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants