Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collection of device's essential information when user want to share feedback #2494

Closed
madhurgupta10 opened this issue Feb 20, 2019 · 15 comments

Comments

@madhurgupta10
Copy link
Collaborator

Summary:
When a user wants to share some feedback, the current scenario does not include the device name, model number, network type, etc.
Automatically adding this to the email template would help the team to address the feedback precisely.
screenshot_20190220-211244

Steps to reproduce:
Open the app < hamburger menu < Feedback

Would you like to work on the issue?
Yes, I want to work on this issue :)

@madhurgupta10 madhurgupta10 changed the title Collection device's essential information when user want to share feedback Collection of device's essential information when user want to share feedback Feb 20, 2019
@madhurgupta10
Copy link
Collaborator Author

@nicolas-raoul Should I keep the support information same for all languages?

@nicolas-raoul
Copy link
Member

@madhurgupta10 Localization would be a good thing, I would say.

@madhurgupta10
Copy link
Collaborator Author

madhurgupta10 commented Feb 21, 2019

@nicolas-raoul Cool, well in that case shall I just create strings in res file for English and translateWiki would take care of the rest, right?

@nicolas-raoul
Copy link
Member

nicolas-raoul commented Feb 21, 2019 via email

@madhurgupta10
Copy link
Collaborator Author

@nicolas-raoul Done, shall I add anything else?
screenshot_20190221-143825

@nicolas-raoul
Copy link
Member

nicolas-raoul commented Feb 21, 2019 via email

@madhurgupta10
Copy link
Collaborator Author

@nicolas-raoul Sure, I will make the changes

madhurgupta10 added a commit to madhurgupta10/apps-android-commons that referenced this issue Feb 21, 2019
@madhurgupta10
Copy link
Collaborator Author

@nicolas-raoul I think keeping the app version in the title would be better than the body, but I can do it, either way, let me know :)

@nicolas-raoul
Copy link
Member

I let you choose what you think is best :-)

@madhurgupta10
Copy link
Collaborator Author

@nicolas-raoul PR is ready :)

@maskaravivek
Copy link
Member

maskaravivek commented Feb 22, 2019

@nicolas-raoul will localising these strings be useful? Most of the people who are part of the commons and commons private Google groups understand English whereas if these meta deta come in any of the ~50-100 supported languages then it might be difficult to interpret.

As these strings would be seen by one who is reading the feedback/logs IMO it would be better not to localise it.

My understanding might be wrong. Please correct me if I am missing something. :)

@nicolas-raoul
Copy link
Member

From the perspective of a non-technical non-English-language person who wants to send feedback about the app, it might be scary to have obscure codes and words in a language you do not understand added to your feedback.

For us English-speaking developers the content sounds obvious, but imagine you want to send feedback about something and this text gets attached to your email:

الشركة المصنعة 98942367423962
الجهاز 460234530942
موديل 49386243968

Would you press Send? Would you not be at least a little bit tempted to erase it or not send the email at all?
That being said, I am also OK with not localizing that part.

@madhurgupta10
Copy link
Collaborator Author

@nicolas-raoul I agree this will be scary, as the person doesn't know what information is attached to the email. What if we replace --Support-Info-- with something that explains the information attached below like Down below we have added some information which will help developers to help you better, you don't need to change anything below

@nicolas-raoul
Copy link
Member

@madhurgupta10 I think Technical information would be clear enough :-)

@madhurgupta10
Copy link
Collaborator Author

@nicolas-raoul @maskaravivek Okay 👍 I will make the changes, thanks for the discussion :)

madhurgupta10 added a commit to madhurgupta10/apps-android-commons that referenced this issue Feb 22, 2019
madhurgupta10 added a commit to madhurgupta10/apps-android-commons that referenced this issue Feb 23, 2019
madhurgupta10 added a commit to madhurgupta10/apps-android-commons that referenced this issue Feb 23, 2019
maskaravivek pushed a commit that referenced this issue Feb 26, 2019
* Add Device Support Information to Feedback Intent #2494

* Update Device Support Information for Feedback Intent #2494

* Update Device Support Information and used common method for Feedback Intent #2494

* Optimise code for Device Support Information for Feedback Intent #2494
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants