Fix issue #1163: Crash on upload picture with right to left languages #1172
Conversation
diddypod
changed the title
|
Can you please resolve the conflicts, so that I can test it easier? |
|
@diddypod Can you run |
…, the GPS data is extracted and attached correctly.
… languages (2 folders in design/screenshots, 8 files each). All screenshots are ordered and follow the same pattern with the current English ones on the Google Play app page.
* Made the following changes: ->Added OpenCV library to the project ->Added functionality to detect if an image being uploaded is too dark ->Added functionality to detect if an image being uploaded is blurred * Made corrections and changes based on gradle checkstyle requirements * Updated gitignore to remove binary files related to OpenCV from project * Image blurriness detection was undone. Images are checked only for being too dark now * Removed OpenCV documentation folder containing a lot of html files * Removed unnecessary buildScript usage in build.gradle file for opencv library and also added abi splits * Removed OpenCV library usages and references from project * Removed OpenCV library folder from project
I haven't found a good page yet about taking screencasts
…, the GPS data is extracted and attached correctly.
Codecov Report
@@ Coverage Diff @@
## master #1172 +/- ##
=========================================
- Coverage 3.81% 3.81% -0.01%
=========================================
Files 125 125
Lines 5812 5821 +9
Branches 568 570 +2
=========================================
Hits 222 222
- Misses 5575 5584 +9
Partials 15 15
Continue to review full report at Codecov.
|
|
@neslihanturan @nicolas-raoul I've rebased as asked. Please check. |
|
@diddypod I want to merge this as soon as possible to merge #1162 as soon as possible. However this PR cas conflicts besides we saw several commits from other people means you need to rebase it. If you follow our document https://github.com/commons-app/apps-android-commons/wiki/Setting-up-dev-enviroment you will be able to create a mergable PR with no problem. |
|
@neslihanturan, I rebased as asked. Sorry for the delay |
| if (ViewCompat.getLayoutDirection(getView()) == ViewCompat.LAYOUT_DIRECTION_LTR) { | ||
| value = titleEdit.getRight() - titleEdit.getCompoundDrawables()[2].getBounds().width(); | ||
| if (motionEvent.getAction() == ACTION_UP && motionEvent.getRawX() >= value) { | ||
| new AlertDialog.Builder(getContext()) |
There was a problem hiding this comment.
the logic for creating a alert dialog is duplicated. It can be extracted out to a function.
There was a problem hiding this comment.
That was careless of me, I overlooked it. I'll correct it and push immediately.
|
Thanks @diddypod ! Congratz your first time contribution:) |
Fix crash on trying to upload pictures while phone language is a RTL language
Fixes #1163
Error was caused because the positions of elements on the screen were hard-coded assuming LTR layouts. I fixed it by checking the layout direction and proceeding accordingly.