Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue #1224 showing complete notification on click #1233

Closed
wants to merge 4 commits into from

Conversation

Jatin0312
Copy link
Contributor

Description

Fixes #1224
Created custom Text View for Title and description which will be clickable and displays complete text if clicked.

Screenshots showing what changed

solved

@codecov-io
Copy link

codecov-io commented Mar 1, 2018

Codecov Report

Merging #1233 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1233   +/-   ##
======================================
  Coverage    3.78%   3.78%           
======================================
  Files         125     125           
  Lines        5861    5861           
  Branches      578     578           
======================================
  Hits          222     222           
  Misses       5624    5624           
  Partials       15      15
Impacted Files Coverage Δ
...nrw/commons/notification/NotificationRenderer.java 0% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c3513b...6e9ea26. Read the comment docs.

@maskaravivek
Copy link
Member

Thanks for implementing this @Jatin0312. A couple of feedbacks:

  • use a diffrentiating font style for more button. As of now it looks like it is the part of notification itself.
  • most apps that implement more also have a less option to go back to the original state.

@Jatin0312
Copy link
Contributor Author

Sure will work on this.

@Jatin0312 Jatin0312 closed this Mar 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants