Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dependencies to com.android.support.test.rules and runner #1575

Merged
merged 1 commit into from
Jun 1, 2018

Conversation

whym
Copy link
Collaborator

@whym whym commented Jun 1, 2018

Add dependencies to com.android.support.test.rules and runner

Fixes #1574 (SettingsActivityTest fails due to undeclared dependencies).

Description

Tests performed

  • Local unit tests - no error
  • Travis-CI tests (from my account) - pass

Needed for ActivityTestRule used in SettingsActivityTest
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@30e5312). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             master   #1575   +/-   ##
========================================
  Coverage          ?   3.91%           
========================================
  Files             ?     146           
  Lines             ?    7450           
  Branches          ?     714           
========================================
  Hits              ?     292           
  Misses            ?    7141           
  Partials          ?      17

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30e5312...c123767. Read the comment docs.

@maskaravivek maskaravivek merged commit 46dcb8b into commons-app:master Jun 1, 2018
@whym whym deleted the settingsactivitytest branch June 2, 2018 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants