Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Appetize badge #2866

Merged
merged 2 commits into from
May 8, 2019
Merged

Conversation

madhurgupta10
Copy link
Collaborator

Description
Fixes #2842 Hosting App on Appetize

What changes did you make and why?
Hosted 2.10.2 on Appetize and added the badge so that people can try it out.

@codecov-io
Copy link

codecov-io commented Apr 6, 2019

Codecov Report

Merging #2866 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #2866   +/-   ##
======================================
  Coverage    3.42%   3.42%           
======================================
  Files         246     246           
  Lines       12193   12193           
  Branches     1071    1071           
======================================
  Hits          418     418           
  Misses      11744   11744           
  Partials       31      31

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07c335e...182cec4. Read the comment docs.

@domdomegg
Copy link
Member

In the discussion at #2842 (comment) there is "we will not advertise appetize.io as a mainstream way to try the app, as we would quickly overflow the free tier". Has this issue been fixed?

@madhurgupta10
Copy link
Collaborator Author

@domdomegg No that issue is not fixed, we will have 100 min per month, but I think that only a few people use the app this way, as it's sole purpose is to get the look of the app on different devices without building/installing.

README.md Show resolved Hide resolved
@madhurgupta10
Copy link
Collaborator Author

@nicolas-raoul @misaochan Please review the PR :)

Copy link
Collaborator

@neslihanturan neslihanturan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine but I think discussion is not finalized. At least I didn't understand the result of the discussion.

Copy link
Collaborator

@neslihanturan neslihanturan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@neslihanturan neslihanturan merged commit 2164fb0 into commons-app:master May 8, 2019
@madhurgupta10 madhurgupta10 deleted the issue-2842 branch May 10, 2019 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hosting app on Appetize
5 participants