Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Screenshots #3313

Closed
wants to merge 3 commits into from
Closed

Conversation

shreyanshagrawal
Copy link

Add Screenshots

Fixes #960 Create screenshots for YOURLANGUAGE

I have added screenshots for Google Code In task.

@codecov-io
Copy link

codecov-io commented Dec 31, 2019

Codecov Report

Merging #3313 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #3313   +/-   ##
======================================
  Coverage     7.5%    7.5%           
======================================
  Files         255     255           
  Lines       11206   11206           
  Branches      895     895           
======================================
  Hits          841     841           
  Misses      10303   10303           
  Partials       62      62

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b591fdd...14f87be. Read the comment docs.

@madhurgupta10
Copy link
Collaborator

@shreyanshagrawal Hi, thanks for your contribution. Could you please update the folder structure as per standard. See PR #1053 for example.

@madhurgupta10
Copy link
Collaborator

@nicolas-raoul What do you think?
I think the folder name should be marketing/screenshots/Hindi hi-IN/ instead of marketing/screenshots/Hindi hi-IN shreyanshagrawal/

@nicolas-raoul
Copy link
Member

@madhurgupta10 Indeed, you are right. That being said, it is difficult to get everything perfect, so I always do a bit of cleanup after GCI.

More importantly, this is the wrong repository. @shreyanshagrawal would you mind sending the same pull request to the https://github.com/commons-app/marketing repository instead? Thanks!

@madhurgupta10
Copy link
Collaborator

@nicolas-raoul I think we can close this PR.
@shreyanshagrawal If you like to contribute please send a new PR to https://github.com/commons-app/marketing

@domdomegg
Copy link
Member

@shreyanshagrawal thank you very much for your contribution, please can you make it at https://github.com/commons-app/marketing

@domdomegg domdomegg closed this Mar 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create screenshots for YOURLANGUAGE
5 participants