Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes : #4855 Copyright warning for beta flavor #4873

Merged

Conversation

Rishavgupta12345
Copy link
Contributor

Fixes: #4855 Copyright warning for beta flavor

adding a cute little popup at the beginning of first time tutorial (only for beta users)

screenshot:-
Screenshot 2022-02-28 195758

@codecov
Copy link

codecov bot commented Feb 28, 2022

Codecov Report

Merging #4873 (0e642b7) into master (9431e37) will decrease coverage by 0.11%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #4873      +/-   ##
============================================
- Coverage     50.57%   50.45%   -0.12%     
+ Complexity     2224     2217       -7     
============================================
  Files           338      338              
  Lines         15546    15553       +7     
  Branches       1359     1359              
============================================
- Hits           7862     7848      -14     
- Misses         7100     7119      +19     
- Partials        584      586       +2     
Impacted Files Coverage Δ
...main/java/fr/free/nrw/commons/WelcomeActivity.java 82.50% <100.00%> (+3.71%) ⬆️
...fr/free/nrw/commons/review/ReviewPagerAdapter.java 30.76% <0.00%> (-38.47%) ⬇️
...r/free/nrw/commons/explore/media/MediaConverter.kt 71.42% <0.00%> (-23.81%) ⬇️
.../nrw/commons/category/CategoryContentProvider.java 12.50% <0.00%> (-14.29%) ⬇️
...w/commons/upload/categories/BaseDelegateAdapter.kt 35.29% <0.00%> (-11.77%) ⬇️
.../java/fr/free/nrw/commons/review/ReviewHelper.java 77.77% <0.00%> (-5.56%) ⬇️
...ava/fr/free/nrw/commons/review/ReviewActivity.java 47.28% <0.00%> (-3.11%) ⬇️
...va/fr/free/nrw/commons/category/CategoriesModel.kt 57.62% <0.00%> (-1.70%) ⬇️
...a/fr/free/nrw/commons/review/ReviewController.java 91.86% <0.00%> (+12.79%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9431e37...0e642b7. Read the comment docs.

Copy link
Member

@nicolas-raoul nicolas-raoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cute image, but I think taking a few kilobytes for this image is a luxury we can unfortunately not afford, as we try to make the APK as small as possible (our most valuable users have very slow/costly Internet connections).
Sorry for putting a damper on the party, but would you mind removing the image? Thanks a lot! :-)

@Rishavgupta12345
Copy link
Contributor Author

Rishavgupta12345 commented Mar 3, 2022

Cute image, but I think taking a few kilobytes for this image is a luxury we can unfortunately not afford, as we try to make the APK as small as possible (our most valuable users have very slow/costly Internet connections). Sorry for putting a damper on the party, but would you mind removing the image? Thanks a lot! :-)

@nicolas-raoul @4D17Y4 done the change, sorry for adding an unnecessary Image😔

@nicolas-raoul nicolas-raoul merged commit 824a82a into commons-app:master Mar 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Copyright warning for beta flavor
2 participants