Resolved Issue #33 #34
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| $(document).ready(function() { | ||
|
|
||
| var scrollLink = $('.scroll'); | ||
|
|
||
| // Smooth scrolling | ||
| scrollLink.click(function(e) { | ||
| e.preventDefault(); | ||
| $('body,html').animate({ | ||
| scrollTop: $(this.hash).offset().top | ||
| }, 1000 ); | ||
| }); | ||
|
|
||
| // Active link switching | ||
| $(window).scroll(function() { | ||
|
There was a problem hiding this comment. I generally think it would be nice to achieve something simple as this without custom JS (possibly using CSS; there's already a PR (#32) which does just this). Not using JS has the advantage that it doesn't require maintainence :-) There was a problem hiding this comment. I also thought of using CSS initially but for time delay and stuff, js is required. |
||
| var scrollbarLocation = $(this).scrollTop(); | ||
|
|
||
| scrollLink.each(function() { | ||
|
|
||
| var sectionOffset = $(this.hash).offset().top - 20; | ||
|
|
||
| if ( sectionOffset <= scrollbarLocation ) { | ||
| $(this).parent().addClass('active'); | ||
| $(this).parent().siblings().removeClass('active'); | ||
| } | ||
| }) | ||
|
|
||
| }) | ||
|
|
||
| }) | ||
File renamed without changes.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could see the reason why you're using
fixed-topfor the navbar but it seems to be making the text ("Commons Mobile App") within the<h1>contained within<div class="jumbotron jumbotron-fluid">to be very close to the navbar in the desktop view and it even goes under the navbar in mobile view. Can you fix this?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BTW, sorry for the late request of change. Couldn't get my hands on this for a while :-(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I managed to fix this issue in 4ff0f4c