Updated - Navigation Bar Styling, animation, highlights active section and page smooth scrolling etc. #32
Conversation
Automatically update links in a navigation list based on scroll position
wikimedia commons logo added as favicon.
On clicking on the navigation links, it scrolls smoothly to the section.
NavBar: * Styling and coloring. * Animation of active link. * Added comments to all added codes.
0xSG
changed the title
0xSG
changed the title
|
Hi. This is Surya here. The code which i added is tested and it's live at here. |
|
Hi @0xpulsar, Just saw the live website. The changes seems to be nice. But the favicon doesn't seem to have come into effect. I still see no icon in the tab for the website. Any idea why? |
|
Let me check. |
|
@sivaraam Can you fix it? |
Just to be sure, fix what? Fix the missing website icon? |
The root of the website that goes live might not be the current directory. So, expecting the 'images' folder to be in the root is not valid. Referencing the 'images' folder relatively fixes this issue.
|
Anyways, I guess I've found the issue. I made a PR to your repo with the fix. 0xSG#1 You could see it live at https://sivaraam.github.io/commons-app.github.io/ |
…sar-pr Correctly specify the icon file for the browser to identify
|
@sivaraam, I have merged and solved merge conflict. can you review it?. |
|
@0xpulsar On a cursory view, I guess the merge isn't proper. You seem to be including styles from both bootstrap 4.0.0-alpha and 4.1.1 as a consequence of which the page looks odd at some places. Could you re-merge it properly? |
Features added:
-- Styling and Coloring.
-- Animation of active link.