Fix flask api limiter issue #318
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The test Flask versions are below: |
Open
|
It would be nice to add Line 26 in c166e64 |
|
alright! |
|
@amirouche done. |
amirouche
reviewed
Dec 1, 2021
build.sh
Outdated
| @@ -30,4 +30,4 @@ check_db () { | |||
| check_disk_space | |||
| pip3 install -e '.[vectors]' | |||
| check_db | |||
| snakemake --resources 'ram=30' -j 2 $@ | |||
| snakemake --resources 'ram=30' -j$(nproc) $@ | |||
There was a problem hiding this comment.
It is better to use nproc --ignore=1 so that when the build.sh is run there is still some cpu available to do stuff.
|
oh sorry I was supposed to make separate PRs. Sorry for the confusion. |
tae898
force-pushed
the
master-original
branch
from
190f66f
to
b9db176
Compare
|
Corrected! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue